11 posts / 0 new
Last post
illspecko
illspecko's picture
Member
Offline
Last seen: 11 years 11 months ago
Joined: 04/03/2011 - 04:10
Karma: 32
[MERGED] Adding Rentable Rooms

First, I want to say thank you for creating this great mod, I'm having a great time rediscovering my favorite island again.

I have some very minor experience with modding in tes, and games in general, so I thought that I should try to make myself useful, and found this tutorial on adding room rental. My plan was to mod the Eight Plates in Balmora to have rentable beds, and upload it here, but unfortunetly, my minor experience with the tesC turned out to be... minor.

I've got the script to compile, and the topic show up in the dialogue for the innkeeper, so far so good. To bad that the door is unlocked when it shouldn't, and when I choose the "I'll take it" option, the innkeeper think I don't have enough gold.

I'm gonna try again with whole other inn and make it from scratch, but I thought that if someone on the forum could take a look and see if they can recognise any faults?

It's  the BalmoraVSEightSplates cell, and the script is called "Publican_EightPlatesDulneaRalaal".

[deleted the old file]

Edited by: thermador on 06/11/2012 - 15:52
thermador
thermador's picture
Administrator
Offline
Last seen: 4 years 4 months ago
Joined: 12/16/2010 - 04:00
Karma: 1398
Donor
Help

Thanks for volunteering to help!  I am at work, so I can't look at your mod, but...

The must-read articles on using the CS include:

Once you've read all those, you'll probably be a lot more confident in your CS skills... in addition to the innkeeper tutorial you mentioned.

Regarding Inns, a list of all of them is here: http://www.uesp.net/wiki/Morrowind:Inns  Note that a few of them don't offer beds, and that the "gold" column is the amount of gold the merchant has, NOT what they charge for a bed - ALL the beds are 10 gold. A list of all of the Innkeepers is here, should come in handy if you don't already have it: http://www.uesp.net/wiki/Category:Morrowind-Publican

Script names can be anything, they don't have to be whatever the tutorial says.  In Morroblivion, you will probably notice that a lot of scripts begin with 'fbmw' and then an identifier so that we know what they are.  For example, fbmwMQ01 is the name of the first Main Quest, fbmgTG01 is the name of the first theives guild quest, etc.  Please use stick to this naming convention - so you might want to name each script: fbmwPublican_InnNameNPCname  --  it makes it a lot easier to find things later.

 

 

Dave B
Dave B's picture
Member
Offline
Last seen: 12 years 4 months ago
Joined: 09/04/2010 - 03:20
Karma: 1692
Renting Rooms
That's great, thank you. You really need to be more careful. This mod has 3070 scripts flagged as having been changed. This is commonly referred to as a "dirty mod." It looks like you did a "Recompile All," which you should only do to find bugs, and then only if you quit without saving right afterwards. However, this is easy enough for me to edit out that there is no reason to start over. Just, please, be more careful. The problem is dialog, not the script. All three of your responses under "BedYes" should do the GetItemCount "Run On Target," but only the first one does.
illspecko
illspecko's picture
Member
Offline
Last seen: 11 years 11 months ago
Joined: 04/03/2011 - 04:10
Karma: 32
Thanks for the fast help, It

doublepost

illspecko
illspecko's picture
Member
Offline
Last seen: 11 years 11 months ago
Joined: 04/03/2011 - 04:10
Karma: 32
Thanks for the fast help, It

Thanks for the fast help, It made the trick! But I'm starting over anyway, I think I have fiddled and just experimenting in general in that ESP. I will start on a new one, would it be alright to make one esp for Balmora, upload, then start over an make another city etc etc? And, is it alright that when I'm at it, change the npc to have similar hairstyle and color like in original Morrowind?

Dave B
Dave B's picture
Member
Offline
Last seen: 12 years 4 months ago
Joined: 09/04/2010 - 03:20
Karma: 1692
Yes, Thank You
Yes to everything you said. I would much rather that you send mods as you go rather than waiting until you have everything finished. There are a lot of rooms in Vvardenfell, and it is easier for me to check and integrate smaller chunks than one massive whole. Changing faces and/or hairstyles would be great, thank you. Please make sure you are always working from the latest master.
illspecko
illspecko's picture
Member
Offline
Last seen: 11 years 11 months ago
Joined: 04/03/2011 - 04:10
Karma: 32
I've been familiarizing

I've been familiarizing myself with the tool these past days, and started to work with the Halfway Tavern in Pelagiad. The dialogue seems to work, it checks for 10 gold, and changes ownership of the bed when you buy.

But I can't make door to be locked when the room isn't rented. What else is there than to set ownership, click persistent reference, lock it up and give it a nice reference in the script? I'm sorry that I need more help than contributing, but if you can help me with this I can start making myself useful. I'm uploading the file. in this esp only the halfway tavern is modded, the script is fbmwPublican_HalfwayTavernDrelasaRamothran

Dave B
Dave B's picture
Member
Offline
Last seen: 12 years 4 months ago
Joined: 09/04/2010 - 03:20
Karma: 1692
Initially Misread Your Script
Sorry, I had initially misread your script and made a bad post based on it. The only thing I can see that may be causing this not to work, is the game may need more time between closing the door and locking it. Try setting this in two separate routines, like an activator in the room or a trigger zone, that checks the ownership of the bed, and if not owned by the player, locks the door.
Dave B
Dave B's picture
Member
Offline
Last seen: 12 years 4 months ago
Joined: 09/04/2010 - 03:20
Karma: 1692
Player Not In Cell
You have this set such that the triggers happen when the player is not in the cell, but scripts are not going to run when the player is not in the cell, so I don't think this will ever flag cleanup properly. Try removing that one criteria Player.GetinCell PelagiadVSHalfwaySTavern == 0.
illspecko
illspecko's picture
Member
Offline
Last seen: 11 years 11 months ago
Joined: 04/03/2011 - 04:10
Karma: 32
I have a working esp now. I

I have a working esp now. I don't know what was wrong in pelagiad, I think it might have been me using a savegame. I went back to another esp where I got one inn working. Now It seems to work. The dialogue options are nearly identical to each other, but that's it how it was in Morrowind. I have altered the appearance of the innkeepers, making them older and having haircuts more like their morrowind counterpart.

I haven't experienced any problems, as long as you start a new game with it. All the inns in Balmora have rentable rooms now.

 

Dave B
Dave B's picture
Member
Offline
Last seen: 12 years 4 months ago
Joined: 09/04/2010 - 03:20
Karma: 1692
Thank You
Release will hopefully be tomorrow, but maybe Sunday.